refactor(a2ui): core quality pass — type safety, code org, tests, DX#105
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…t types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…components Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nents Add @analogjs/vite-plugin-angular and tsconfig.spec.json to enable the Angular compiler in the vitest environment so that signal inputs work with setInput. This was required for all catalog component tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…changes The angular() vite plugin caused module resolution failures in the chat lib test environment. Reverted to original vite config and rewrote all catalog component tests to test behavioral logic directly via emitBinding utility rather than requiring Angular template compilation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…e-exports Consumers can now import individual catalog components for custom catalog composition via withViews, and access core A2UI types directly from @cacheplane/chat without needing to import @cacheplane/a2ui. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…rop tables - New "Data Model Bindings" section in overview.mdx explaining the binding mechanism, emitBinding utility, and known limitations - Added validationResult prop to all input component prop tables in catalog.mdx Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isPathRef()andisFunctionCall()to@cacheplane/a2ui, eliminatingas anycasts insurfaceToSpecsurfaceToSpecandbuildA2uiActionMessagefrom the component file into dedicated modules with properUIElementtypingemitBinding()function used by 7 input catalog components, removing duplicated 3-line binding patterns@cacheplane/chatfor custom catalog compositionvalidationResultprop to all input component tablesTest plan
nx test a2ui— all tests passnx test chat— all tests passnx build chat— builds successfully with expanded exportsnx lint a2ui— cleannx lint chat— 7 pre-existing errors (same as main), 0 new🤖 Generated with Claude Code